Welcome, Guest. Please login or register. Please note that you need to register seperately to use this forum.
September 10, 2010, 03:40:26 PM
Jomres.net ForumsJomres LiteJomres LiteNo vacancies at this time!
Pages: [1] 2
Print
Author Topic: No vacancies at this time!  (Read 1570 times)
Codger
Newbie
*
Posts: 11


View Profile
« on: January 19, 2010, 02:59:22 PM »

Hi all,

If I use a 'book now' button I am taken to the first available date but the form head says "No vacancies at this time!" If I then select a different available date from the drop-down it works OK and if I then return to the first availble date it also now works.

Is this a bug, or am I missing something? http://www.cottageholidayswales.com/availability

Codger
Logged
Vince
Administrator
Hero Member
*****
Posts: 4649



View Profile
« Reply #1 on: January 20, 2010, 10:54:28 AM »

See this change which I believe resolves that problem:

https://jomres.trac.cvsdude.com/Jomres_core_v4/changeset/730
Logged

Don't PM me, if you need to get in touch, please raise a support ticket.
For Jomres Lite support, please visit http://www.opensourcesupportdesk.com/
Codger
Newbie
*
Posts: 11


View Profile
« Reply #2 on: January 20, 2010, 07:05:49 PM »

Thanks, Vince. I am grateful for your response.

However, I don't appear to have that file.  Angry

This is how it looks:-
http://www.cottageholidayswales.com/changeset730.gif

I am probably being very dumb here - sorry.

Codger
Logged
JK1
Sr. Member
****
Posts: 424


View Profile
« Reply #3 on: January 20, 2010, 08:15:41 PM »

Perhaps you are running an old version of Jomres?  Roll Eyes See here: https://jomres.trac.cvsdude.com/Jomres_core_v4/changeset/579/jomres/libraries/jomres/functions

I think before v4.2 it was in /httpdocs/jomres folder, but I'm not shure.
« Last Edit: January 20, 2010, 08:19:53 PM by JK1 » Logged
Codger
Newbie
*
Posts: 11


View Profile
« Reply #4 on: January 20, 2010, 11:21:46 PM »

I am running 4.2.1 lite

Codger
Logged
Codger
Newbie
*
Posts: 11


View Profile
« Reply #5 on: January 22, 2010, 09:34:16 PM »

Vince, what have you done to this topic? After the first page, "next" takes us to a different thread!

Codger
Logged
JK1
Sr. Member
****
Posts: 424


View Profile
« Reply #6 on: January 22, 2010, 10:34:36 PM »

If you are still searching for the dobooking.php file, you could install the eXtplorer on your website: http://extensions.joomla.org/extensions/core-enhancements/file-management/2630

If the file is in one of your website's directories, it will find it when you use it's search utility.
« Last Edit: January 22, 2010, 10:38:59 PM by JK1 » Logged
Codger
Newbie
*
Posts: 11


View Profile
« Reply #7 on: January 30, 2010, 06:29:37 PM »

Thanks JK1 for the suggestion.

I have located the file at /jomres/dobooking.php but the line numbers don't match the r711. The code $load['ONLOAD']="show_log();"; is at line 391 on my version. I tried making the change there but it threw an error, so I reversed the change.  Undecided

Codger
Logged
Vince
Administrator
Hero Member
*****
Posts: 4649



View Profile
« Reply #8 on: February 04, 2010, 08:14:39 AM »

Sorry JK1 but the changes you note will only affect a 4.4 or greater version of Jomres. Lite is still using the old "two pass" method of processing the booking form.
Logged

Don't PM me, if you need to get in touch, please raise a support ticket.
For Jomres Lite support, please visit http://www.opensourcesupportdesk.com/
Codger
Newbie
*
Posts: 11


View Profile
« Reply #9 on: February 08, 2010, 11:19:04 AM »

Forgive me Vince, but I am unsure what to conclude from this. Is 4.2.1 Lite broken, then?

Codger
Logged
Vince
Administrator
Hero Member
*****
Posts: 4649



View Profile
« Reply #10 on: February 08, 2010, 11:35:31 AM »

No, it just means that if you go into an SRP that uses fixed period bookings from the book now link the room internally isn't fully initialised (if I understand your problem correctly). It works ok from the availability calendar and it works fine in MRPs in any configuration.

There is some code in play to correct the issue, and as far as I know it works ok, but for some reason it's not working for you. The code's in j00015viewproperty.class.php and it is as follows:

$url=JOMRES_SITEPAGE_URL."&task=dobooking&selectedProperty=$property_uid";
if ( (($mrConfig['fixedArrivalDateYesNo']=='1'|| $mrConfig['fixedPeriodBookings']=='1')) && !isset($tmpBookingHandler->tmpsearch_data['jomsearch_availability_departure']) ) // We'll add an invalid arrival date if the fixed arrival date setting is set to Yes. This way we can force the booking engine to see the arrival date is wrong and it'll rebuild the available rooms list, which it doesn't if the date is correct when coming from the Book a room link.
  $url.="&arrivalDate=2009-01-01";

What that's doing is
1. Setting the url to the booking form
2. Asking if a number of scenarios aren't met. If they're not, add an invalid date to the end of the url. Doing this completes the initialisation internally.

By the sounds of it, for you that invalid date isn't being added to the url.

I believe that JK1 has a number of properties with a similar configuration, to the best of my knowledge this isn't an issue at all in 4.(5 with the change noted above).

Logged

Don't PM me, if you need to get in touch, please raise a support ticket.
For Jomres Lite support, please visit http://www.opensourcesupportdesk.com/
Codger
Newbie
*
Posts: 11


View Profile
« Reply #11 on: February 08, 2010, 05:32:13 PM »

Thanks for the response - it is appreciated.

I can confirm that the code you quoted is present and correct.
I can also confirm that (for me, at least) the date suffix is absent from the displayed url. However, if I add it (the code date of 2009-01-01) manually it still shows "No vacancies at this time!".

I have been testing different date suffixes and it appears that it behaves as expected only when the (invalid) date is in fact available. To me this seems natural enough, but I do understand that coding is not that straightforward.

Does this information give anyone a clue to where the problem might lie?
« Last Edit: February 09, 2010, 10:17:42 AM by Codger » Logged
cdwm
Newbie
*
Posts: 28


View Profile
« Reply #12 on: February 09, 2010, 08:44:17 PM »

I'm running 4.4 and am having this issue as well at http://hlcenterprises.com/index.php?option=com_content&view=article&id=1&Itemid=3 and I did make the change from the previous post.

I have a fake booking for March 12-14 set up for testing purposes. So if you choose those dates and click search, the booking form correctly displays that "We have no vacancies" (besides the incorrect date being carried from the search form-I'm working on that separately) which is correct.

If you change the dates to a week later for instance, it still displays "no vacancies" yet adds the Accommodation Total of ( x nights ) and displays all pricing correctly, letting you proceed with the rest of the form.
Logged
jskillet
Newbie
*
Posts: 7


View Profile
« Reply #13 on: February 09, 2010, 11:06:23 PM »

I'm also running 4.4 and having the same problem. If anyone gets this figured out, please share what you did to resolve this. It will be much appreciated.
Logged
Gecko
Jr. Member
**
Posts: 81


View Profile WWW
« Reply #14 on: February 25, 2010, 09:54:19 AM »

For the two posts immediately above this one, I think that http://forum.jomres.net/index.php?topic=2979.0 solves your problem.
Logged
Pages: [1] 2
Print
Jump to:  

augean-entrant